hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Omkar Vinit Joshi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1036) Distributed Cache gives inconsistent result if cache files get deleted from task tracker
Date Wed, 07 Aug 2013 23:00:49 GMT

    [ https://issues.apache.org/jira/browse/YARN-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13732887#comment-13732887
] 

Omkar Vinit Joshi commented on YARN-1036:
-----------------------------------------

Thanks for updating it...

few more comments.
bq. rsrc == null (I can't fathom why it would be), but still. 
I don't think it will ever be null in LOCALIZED case. lets isolate them.

bq. +      } //No break here. Falling through.
lets put break;

Regarding test code

bq. +      LocalizedResource lr1 = createLocalizedResource(req1, dispatcher);

why are we creating LocalizedResource? Probably we don't need to create one and control explicitly..
We can monitor dispatch queue. thoughts?

bq. +          "file:///tmp/r1"), 1);
lets not have hard coded paths.. will fail on windows (as you are also creating one file).
Also try to create file in current working directory instead.

probably you can take a look at TestLocalResourcesTrackerImpl#testHierarchicalLocalCacheDirectories
(trunk)
                
> Distributed Cache gives inconsistent result if cache files get deleted from task tracker

> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-1036
>                 URL: https://issues.apache.org/jira/browse/YARN-1036
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 0.23.9
>            Reporter: Ravi Prakash
>            Assignee: Ravi Prakash
>         Attachments: YARN-1036.branch-0.23.patch, YARN-1036.branch-0.23.patch
>
>
> This is a JIRA to backport MAPREDUCE-4342. I had to open a new JIRA because that one
had been closed. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message