hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Kniest (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1019) YarnConfiguration validation for local disk path and http addresses.
Date Sat, 10 Aug 2013 22:52:48 GMT

    [ https://issues.apache.org/jira/browse/YARN-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13736098#comment-13736098
] 

Joseph Kniest commented on YARN-1019:
-------------------------------------

So if I find this:

public AppReportFetcher(Configuration conf) {
    this.conf = conf;
    YarnRPC rpc = YarnRPC.create(this.conf);
    InetSocketAddress rmAddress = conf.getSocketAddr(
            YarnConfiguration.RM_ADDRESS,
            YarnConfiguration.DEFAULT_RM_ADDRESS,
            YarnConfiguration.DEFAULT_RM_PORT);
.
.
.

before that call at the bottom of the snipped should I have some logic that throws an exception
if YarnConfiguration.RM_ADDRESS isn't in a valid format? Is that what we want to be doing
in all the various places in the codebase where this object's fields are accessed?
                
> YarnConfiguration validation for local disk path and http addresses.
> --------------------------------------------------------------------
>
>                 Key: YARN-1019
>                 URL: https://issues.apache.org/jira/browse/YARN-1019
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Omkar Vinit Joshi
>            Priority: Minor
>              Labels: newbie
>
> Today we are not validating certain configuration parameters set in yarn-site.xml. 1)
Configurations related to paths... such as local-dirs, log-dirs.. Our NM crashes during startup
if they are set to relative paths rather than absolute paths. To avoid such failures we can
enforce checks (absolute paths) before startup . i.e. before we actually startup...( i.e.
directory handler creating directories).
> 2) Also for all the parameters using "hostname:port" unless we are ok with default port.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message