hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-643) WHY appToken is removed both in BaseFinalTransition and AMUnregisteredTransition AND clientToken is removed in FinalTransition and not BaseFinalTransition
Date Thu, 01 Aug 2013 18:55:55 GMT

    [ https://issues.apache.org/jira/browse/YARN-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13726740#comment-13726740
] 

Jian He commented on YARN-643:
------------------------------

Few comments on the patch:

- The tokens are first removed inside AMUnregisteredTransition, it will once again be removed
in FinalTransition. 
- can you create a common function for removing these tokens instead of replicating the code
?
                
> WHY appToken is removed both in BaseFinalTransition and AMUnregisteredTransition AND
clientToken is removed in FinalTransition and not BaseFinalTransition
> ----------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-643
>                 URL: https://issues.apache.org/jira/browse/YARN-643
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Jian He
>            Assignee: Xuan Gong
>         Attachments: YARN-643.1.patch, YARN-643.2.patch
>
>
> The jira is tracking why appToken and clientToAMToken is removed separately, and why
they are distributed in different transitions, ideally there may be a common place where these
two tokens can be removed at the same time. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message