hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikas Saha (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-937) Fix unmanaged AM in non-secure/secure setup post YARN-701
Date Fri, 26 Jul 2013 18:59:50 GMT

    [ https://issues.apache.org/jira/browse/YARN-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13721069#comment-13721069
] 

Bikas Saha commented on YARN-937:
---------------------------------

Vinod and I looked at the token code and translation logic a fair bit and the URI solution
for the name node is actually slightly misleading. The URI is just used as a dummy placeholder.
Internally, ConfiguredProxyProvider does some magic to populate the token cache with the real
ip address after looking up the token using the dummy URI entry.
Anyways, that is a perhaps orthogonal to the code here. After looking at the code, I think
we dont need to look up the addres from config in yarnclientimpl. When the RM creates the
token is populates the service field and so applicationReport.getAMRMToken() returns a token
that has all fields already populated. So we can simply call 
{code}amrmToken = ConverterUtils.convertFromYarn(token, null);{code}
The helper utility populates the service field of the token from the protoToken and then overrides
it with the user supplied addr. Since the AMRMToken already has the service field populated
we dont need to override anything. So we dont need to lookup any address from config in the
YARNClient code. Later, for HA if we need to do some translation, then it should probably
happen via the RMProxy layer. Does that work for you?

Rest of the patch looks good to me. Thanks for taking all the minor comments!

                
> Fix unmanaged AM in non-secure/secure setup post YARN-701
> ---------------------------------------------------------
>
>                 Key: YARN-937
>                 URL: https://issues.apache.org/jira/browse/YARN-937
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.1.0-beta
>            Reporter: Arun C Murthy
>            Assignee: Alejandro Abdelnur
>            Priority: Blocker
>             Fix For: 2.1.0-beta
>
>         Attachments: YARN-937.patch, YARN-937.patch, YARN-937.patch, YARN-937.patch,
YARN-937.patch, YARN-937.patch
>
>
> Fix unmanaged AM in non-secure/secure setup post YARN-701 since app-tokens will be used
in both scenarios.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message