hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Omkar Vinit Joshi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-897) CapacityScheduler wrongly sorted queues
Date Thu, 11 Jul 2013 22:45:49 GMT

    [ https://issues.apache.org/jira/browse/YARN-897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706380#comment-13706380
] 

Omkar Vinit Joshi commented on YARN-897:
----------------------------------------

bq. BTW we are working on a discrete event simulator, which should allow us to lock-step/debug
the entire RM codebase... that would make for easy testing of some of this stuff (more as
soon as we get it ready to show it around).
interesting... 

Yes I am checking it but it seems to have solved the original problem....checked the test
code too seems ok.

bq. The tree is already out of order because of the new usedCapacity, the remove() won't work.
We have to iterate and add() to fix the order.
Yeah you are right... releaseResource has already updated it.
probably the sequence could have been removeFromParentIfPresent, releaseResource , addToParentIfPresent....however
let other folks reply 

                
> CapacityScheduler wrongly sorted queues
> ---------------------------------------
>
>                 Key: YARN-897
>                 URL: https://issues.apache.org/jira/browse/YARN-897
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacityscheduler
>            Reporter: Djellel Eddine Difallah
>         Attachments: TestBugParentQueue.java, YARN-897-1.patch
>
>
> The childQueues of a ParentQueue are stored in a TreeSet where UsedCapacity defines the
sort order. This ensures the queue with least UsedCapacity to receive resources next. On containerAssignment
we correctly update the order, but we miss to do so on container completions. This corrupts
the TreeSet structure, and under-capacity queues might starve for resources.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message