hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-513) Create common proxy client for communicating with RM
Date Mon, 08 Jul 2013 21:23:49 GMT

    [ https://issues.apache.org/jira/browse/YARN-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702443#comment-13702443
] 

Jian He commented on YARN-513:
------------------------------

bq.Does ResourceTrackerClientPBImpl still need a close method after this code? If yes, then
why does this code not call close() instead?
These two methods are separate as one for ResourceTrackerPB.class,the other for ResourceTracker.class.
we can also see this from YarnClientImpl.serviceStop and ApplicationClientProtocolPBClientImpl.close().
Did not investigate into the deep implementations.
bq. Does this need an @VisibleForTesting flag?
This is actually only overridden in test class not directly called in test case.
bq. Why has this been removed in testConnectionNMToRM? Was this redundant earlier? Does some
new test code cover this check?
I don't see the need of testing this. The following assertion "Assert.assertTrue("NM started
before updater triggered",myUpdater.isTriggered());" covers this I think.
bq. Some of the tests probably dont need to wrap the fake ResourceTracker inside a RetryProxy.
Only TestNodeStatusUpdaterRetryAndNMShutdown and testNMConnectionToRM are using the ResourceTracker
inside a RetryProxy, which I think should need.

Agreed with other comments.
                
> Create common proxy client for communicating with RM
> ----------------------------------------------------
>
>                 Key: YARN-513
>                 URL: https://issues.apache.org/jira/browse/YARN-513
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Bikas Saha
>            Assignee: Jian He
>         Attachments: YARN-513.10.patch, YARN-513.11.patch, YARN-513.12.patch, YARN-513.13.patch,
YARN-513.1.patch, YARN-513.2.patch, YARN-513.3.patch, YARN-513.4.patch, YARN.513.5.patch,
YARN-513.6.patch, YARN-513.7.patch, YARN-513.8.patch, YARN-513.9.patch
>
>
> When the RM is restarting, the NM, AM and Clients should wait for some time for the RM
to come back up.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message