Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Thu, 13 Jun 2013 22:35:20 +0000 (UTC)
From: "Siddharth Seth (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12652757.1371161268329.112514.1371162920649@arcas>
In-Reply-To: <JIRA.12652757.1371161268329@arcas>
References: <JIRA.12652757.1371161268329@arcas>
Subject: [jira] [Commented] (YARN-811) Add a set of final _init/_start/_stop
 methods to CompositeService
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682846#comment-13682846 ] 

Siddharth Seth commented on YARN-811:
-------------------------------------

Trying to do this would probably mean that AbstractService would be aware of CompositeService. Depends on whether there's value in doing this. Looking at the code base - there's places where a Composite Service makes a super.start() call in the middle of it's start code - and that may complicate this (MRAppMaster for example)
                
> Add a set of final _init/_start/_stop methods to CompositeService
> -----------------------------------------------------------------
>
>                 Key: YARN-811
>                 URL: https://issues.apache.org/jira/browse/YARN-811
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Siddharth Seth
>             Fix For: 2.1.0-beta
>
>
> Classes which implement AbstractService no longer need to make a super.init, start, stop call. The same could be done for CompositeService as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira