Return-Path: 
 <yarn-issues-return-10214-apmail-hadoop-yarn-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 5C416C25F
	for <apmail-hadoop-yarn-issues-archive@minotaur.apache.org>;
 Thu, 20 Jun 2013 23:59:20 +0000 (UTC)
Received: (qmail 46180 invoked by uid 500); 20 Jun 2013 23:59:20 -0000
Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org
Received: (qmail 46157 invoked by uid 500); 20 Jun 2013 23:59:20 -0000
Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:yarn-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:yarn-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:yarn-issues@hadoop.apache.org>
List-Id: <yarn-issues.hadoop.apache.org>
Reply-To: yarn-issues@hadoop.apache.org
Delivered-To: mailing list yarn-issues@hadoop.apache.org
Received: (qmail 46149 invoked by uid 99); 20 Jun 2013 23:59:20 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Jun 2013 23:59:20 +0000
Date: Thu, 20 Jun 2013 23:59:20 +0000 (UTC)
From: "Alejandro Abdelnur (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12651818.1370644333162.152297.1371772760222@arcas>
In-Reply-To: <JIRA.12651818.1370644333162@arcas>
References: <JIRA.12651818.1370644333162@arcas>
Subject: [jira] [Commented] (YARN-791) Ensure that RM RPC APIs that return
 nodes are consistent with /nodes REST API
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/YARN-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13689874#comment-13689874 ] 

Alejandro Abdelnur commented on YARN-791:
-----------------------------------------

I prefer Hitesh's suggestion that if you don't specify a filter you get everything, this is more intuitive than an implicit filter.

How about?

The HTTP API would be <URL>[?filter=STATE+]. if filter= param is not specified means ALL. if filter= param is specified and it is empty or invalid we return an ERROR response.
The ProtoBuffer would have a filter list. if the list is empty means ALL.
The Java API would have a newInstance() which means ALL.
The Java API would have a newInstance(EnumSet<State> filter). NULL & EnumSet.NONE would throw an IllegalArgumentException. EnumSet.ALL is the same as newInstance().

The change of param name from state to filter seems also a bit more correct and self explanatory.


                
> Ensure that RM RPC APIs that return nodes are consistent with /nodes REST API
> -----------------------------------------------------------------------------
>
>                 Key: YARN-791
>                 URL: https://issues.apache.org/jira/browse/YARN-791
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, resourcemanager
>    Affects Versions: 2.0.4-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-791-1.patch, YARN-791-2.patch, YARN-791-3.patch, YARN-791-4.patch, YARN-791.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira