Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Thu, 6 Jun 2013 21:22:20 +0000 (UTC)
From: "Hitesh Shah (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12650793.1370311319102.81468.1370553740364@arcas>
In-Reply-To: <JIRA.12650793.1370311319102@arcas>
References: <JIRA.12650793.1370311319102@arcas>
Subject: [jira] [Commented] (YARN-759) Create Command enum in
 AllocateResponse
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13677526#comment-13677526 ] 

Hitesh Shah commented on YARN-759:
----------------------------------

Very minor comments. Looks good overall. 

typo in proto: optional AMCommandProto aM_command = 1;

In AMCommand class' javadocs, might be useful to mention that this will be null by default in allocateresponse and that implies ...

distributedshell/ApplicationMaster.java - shouldn't the app kill itself on shutdown? Ok to have this be done in a separate jira. Is there already one filed for this?

Could you please file a separate jira for creating handlers for resync which are linked to stateful RM restart so that this functionality is not forgotten.


> Create Command enum in AllocateResponse
> ---------------------------------------
>
>                 Key: YARN-759
>                 URL: https://issues.apache.org/jira/browse/YARN-759
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>         Attachments: YARN-759.1.patch, YARN-759.2.patch
>
>
> Use command enums for shutdown/resync instead of booleans.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira