hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-811) Add a set of final _init/_start/_stop methods to CompositeService
Date Sat, 15 Jun 2013 12:45:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13684165#comment-13684165
] 

Steve Loughran commented on YARN-811:
-------------------------------------

Siddarth -I see. I went through all the subclasses and when moving them to the {{service[init()|start()|stop()]
methods made sure they delegated to the superclasses {{serviceStart() &c}} methods. 

As of right now, there are not -AFAIK- any calls to {{super.start()}} in the {{serviceStart()}}
startup code of any of the service implementations. If there are, thats something that I should
have caught and fixed -so file a JIRA as a bug and assign it to me.
                
> Add a set of final _init/_start/_stop methods to CompositeService
> -----------------------------------------------------------------
>
>                 Key: YARN-811
>                 URL: https://issues.apache.org/jira/browse/YARN-811
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Siddharth Seth
>             Fix For: 2.1.0-beta
>
>
> Classes which implement AbstractService no longer need to make a super.init, start, stop
call. The same could be done for CompositeService as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message