hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Created] (YARN-804) mark AbstractService init/start/stop methods as final
Date Thu, 13 Jun 2013 17:05:20 GMT
Steve Loughran created YARN-804:
-----------------------------------

             Summary: mark AbstractService init/start/stop methods as final
                 Key: YARN-804
                 URL: https://issues.apache.org/jira/browse/YARN-804
             Project: Hadoop YARN
          Issue Type: Improvement
          Components: api
    Affects Versions: 2.1.0-beta
            Reporter: Steve Loughran


Now that YARN-117 and MAPREDUCE-5298 are checked in, we can mark the public AbstractService
init/start/stop methods as final.

Why? It puts the lifecycle check and error handling around the subclass code, ensuring no
lifecycle method gets called in the wrong state or gets called more than once.When a {{serviceInit(),
serviceStart()  & serviceStop()}} method throws an exception, it's caught and auto-triggers
stop. 

Marking the methods as final forces service implementations to move to the stricter lifecycle.
It has one side effect: some of the mocking tests play up -I'll need some assistance here

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message