hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-686) Flatten NodeReport
Date Wed, 05 Jun 2013 19:10:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13676246#comment-13676246
] 

Hadoop QA commented on YARN-686:
--------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12586361/YARN-686.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 7 new or modified
test files.

    {color:red}-1 javac{color:red}.  The patch appears to cause the build to fail.

Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1127//console

This message is automatically generated.
                
> Flatten NodeReport
> ------------------
>
>                 Key: YARN-686
>                 URL: https://issues.apache.org/jira/browse/YARN-686
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api
>    Affects Versions: 2.0.4-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-686.patch, YARN-686.patch
>
>
> The NodeReport returned by getClusterNodes or given to AMs in heartbeat responses includes
both a NodeState (enum) and a NodeHealthStatus (object).  As UNHEALTHY is already NodeState,
a separate NodeHealthStatus doesn't seem necessary.  I propose eliminating NodeHealthStatus#getIsNodeHealthy
and moving its two other methods, getHealthReport and getLastHealthReportTime, into NodeReport.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message