hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sandy Ryza (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-588) Two identical utility methods in different classes to build Resource
Date Thu, 13 Jun 2013 22:57:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682866#comment-13682866
] 

Sandy Ryza commented on YARN-588:
---------------------------------

In the last case, using 1 will preserve the existing behavior, as the maximum allocation should
never be 0.  I think you'll be safe putting 1 for 1. and 2. as well, but I would run the capacity
scheduler tests to make sure.
                
> Two identical utility methods in different classes to build Resource
> --------------------------------------------------------------------
>
>                 Key: YARN-588
>                 URL: https://issues.apache.org/jira/browse/YARN-588
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: api
>    Affects Versions: 2.0.3-alpha
>            Reporter: Sandy Ryza
>            Assignee: Niranjan Singh
>            Priority: Minor
>              Labels: newbie
>         Attachments: YARN-588.patch, YARN-588.patch
>
>
> Both Resources and BuilderUtils have a method that takes the same arguments to build
a Resource object.  The code doesn't need both of these methods.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message