Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BED0411797 for ; Fri, 10 May 2013 22:37:17 +0000 (UTC) Received: (qmail 11575 invoked by uid 500); 10 May 2013 22:37:17 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 11512 invoked by uid 500); 10 May 2013 22:37:17 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 11190 invoked by uid 99); 10 May 2013 22:37:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 May 2013 22:37:17 +0000 Date: Fri, 10 May 2013 22:37:17 +0000 (UTC) From: "Zhijie Shen (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-572) Remove duplication of data in Container MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13654946#comment-13654946 ] Zhijie Shen commented on YARN-572: ---------------------------------- There are three fields that are duplicate in Container and ContainerTokenIdentifier: 1. ContainerId 2. NodeId 3. Resource Though the fields are duplicated, it seems not good to remove them from Container. 1 and 2 are used to compare the Container objects and the getters of all the three are referred in multiple places tens of times. > Remove duplication of data in Container > ---------------------------------------- > > Key: YARN-572 > URL: https://issues.apache.org/jira/browse/YARN-572 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Hitesh Shah > Assignee: Zhijie Shen > > Most of the information needed to launch a container is duplicated in both the Container class as well as in the ContainerToken object that the Container object already contains. It would be good to remove this level of duplication. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira