hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kumar Vavilapalli (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-711) Copy BuilderUtil methods into individual records
Date Thu, 23 May 2013 18:29:21 GMT

    [ https://issues.apache.org/jira/browse/YARN-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13665459#comment-13665459
] 

Vinod Kumar Vavilapalli commented on YARN-711:
----------------------------------------------

Looked at latest patch. It's close. Few more comments:
 - I think you should leave the IDs for YARN-528.
 - What about ProtoBase? Doing it separately? If so, please file a ticket and report here.
 - LocalResource record has 6 fields. getPattern is optional. The factory method has only
5 parameters, so like AppSubmissionContext, you will have two factory methods one which takes
in a pattern.
                
> Copy BuilderUtil methods into individual records
> ------------------------------------------------
>
>                 Key: YARN-711
>                 URL: https://issues.apache.org/jira/browse/YARN-711
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Jian He
>         Attachments: YARN-711.1.patch, YARN-711.2.patch, YARN-711.3.patch, YARN-711.4.patch,
YARN-711.5.patch
>
>
> BuilderUtils is one giant utils class which has all the factory methods needed for creating
records. It is painful for users to figure out how to create records. We are better off having
the factories in each record, that way users can easily create records.
> As a first step, we should just copy all the factory methods into individual classes,
deprecate BuilderUtils and then slowly move all code off BuilderUtils.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message