hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Siddharth Seth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-710) Add to ser/deser methods to RecordFactory
Date Fri, 31 May 2013 19:29:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671758#comment-13671758
] 

Siddharth Seth commented on YARN-710:
-------------------------------------

bq. On the 3rd one, that would require assuming that I could remove 'PBImpl' from the class,
add 'Proto' and then I get the proto implementation. Plus package swithing. While the 'PBImpl'
postfix is used as a convention already, the 'Proto' and the package are not used as convention,
thus I'd leave it as it is.
Is it possible to just use the return type on the getProto method, instead of creating an
instance ? (Message message = getProto(newRecordInstance(clazz));)

Otherwise, patch looks good to me.
                
> Add to ser/deser methods to RecordFactory
> -----------------------------------------
>
>                 Key: YARN-710
>                 URL: https://issues.apache.org/jira/browse/YARN-710
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: api
>    Affects Versions: 2.0.4-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>         Attachments: YARN-710.patch, YARN-710.patch
>
>
> I order to do things like AMs failover and checkpointing I need to serialize app IDs,
app attempt IDs, containers and/or IDs,  resource requests, etc.
> Because we are wrapping/hiding the PB implementation from the APIs, we are hiding the
built in PB ser/deser capabilities.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message