hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikas Saha (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-582) Restore appToken for app attempt after RM restart
Date Thu, 02 May 2013 23:52:16 GMT

    [ https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13648037#comment-13648037
] 

Bikas Saha commented on YARN-582:
---------------------------------

Is the null check necessary? the underlying protobuf handles the null properly.
{code}
          ByteBuffer appAttemptTokens = attemptState.getAppAttemptTokens();
          if(appAttemptTokens != null){
            attemptStateData.setAppAttemptTokens(appAttemptTokens);
          }
{code}

New public method necessary? RMAppAttemptImpl.recoverAppAttemptTokens()

Looks like all changes in RMAppImpl are unnecessary.

Bug in existing testDelegationTokenRestoredOnRMrestart(). The assert check should be made
for rm1 and also for rm2. Right?
{code}
    // start new RM
    MockRM rm2 = new TestSecurityMockRM(conf, memStore);
    rm2.start();

    // verify tokens are properly populated back to DelegationTokenRenewer
    Assert.assertEquals(tokenSet, rm1.getRMContext()
      .getDelegationTokenRenewer().getDelegationTokens());
{code}
                
> Restore appToken for app attempt after RM restart
> -------------------------------------------------
>
>                 Key: YARN-582
>                 URL: https://issues.apache.org/jira/browse/YARN-582
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Bikas Saha
>            Assignee: Jian He
>         Attachments: YARN-582.1.patch, YARN-582.2.patch, YARN-582.3.patch
>
>
> These need to be saved and restored on a per app attempt basis. This is required only
when work preserving restart is implemented for secure clusters. In non-preserving restart
app attempts are killed and so this does not matter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message