hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kumar Vavilapalli (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-571) User should not be part of ContainerLaunchContext
Date Fri, 24 May 2013 03:00:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13665960#comment-13665960
] 

Vinod Kumar Vavilapalli commented on YARN-571:
----------------------------------------------

Tx for this taking this over.

Patch looks good to me. Except for a couple of things:
 - I don't like these new APIs in BuilderUtils. They are nothing but helper methods, but I
see that you don't have anywhere else to put them. I'll make sure these get fixed via YARN-717.
 - The test code also in TestContainerManagerSecurity needs to removed/modified completely.
But I think leaving them behind like you did is useful for the sake of YARN-684.

+1 for this. Will run all tests once and check this in if they are good.
                
> User should not be part of ContainerLaunchContext
> -------------------------------------------------
>
>                 Key: YARN-571
>                 URL: https://issues.apache.org/jira/browse/YARN-571
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Hitesh Shah
>            Assignee: Omkar Vinit Joshi
>         Attachments: YARN-571-20130415.2.txt, YARN-571-20130418.txt, YARN-571.20130522.1.patch,
YARN-571.20130522.2.patch, YARN-571.20130522.patch
>
>
> Today, a user is expected to set the user name in the CLC when either submitting an application
or launching a container from the AM. This does not make sense as the user can/has been identified
by the RM as part of the RPC layer.
> Solution would be to move the user information into either the Container object or directly
into the ContainerToken which can then be used by the NM to launch the container. This user
information would set into the container by the RM.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message