hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hitesh Shah (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-513) Create common proxy client for communicating with RM
Date Thu, 23 May 2013 22:39:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13665791#comment-13665791
] 

Hitesh Shah commented on YARN-513:
----------------------------------

{code}
public static <T> T createRMProxy(final Configuration conf,
+      final Class<T> protocol, InetSocketAddress rmAddress)
+      throws IOException {
+    if(rmAddress == null)
{code}

For the above, it might be cleaner to have 2 functions - one that accepts rmAddress and one
that does not. 

{code}
return (waitForEver) ? RetryPolicies.RETRY_FOREVER
{code}

Move this code up and just return the policy instead of creating the exceptionMap, etc in
cases where waitForEver is true? 

Indentation is off in TestEventFlow.java?



                
> Create common proxy client for communicating with RM
> ----------------------------------------------------
>
>                 Key: YARN-513
>                 URL: https://issues.apache.org/jira/browse/YARN-513
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Bikas Saha
>            Assignee: Jian He
>         Attachments: YARN-513.1.patch, YARN-513.2.patch, YARN-513.3.patch, YARN-513.4.patch,
YARN.513.5.patch, YARN-513.6.patch, YARN-513.7.patch, YARN-513.8.patch
>
>
> When the RM is restarting, the NM, AM and Clients should wait for some time for the RM
to come back up.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message