Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Mon, 1 Apr 2013 12:37:15 +0000 (UTC)
From: "Steve Loughran (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12640110.1364819291948.85009.1364819835473@arcas>
In-Reply-To: <JIRA.12640110.1364819291948@arcas>
References: <JIRA.12640110.1364819291948@arcas>
Subject: [jira] [Commented] (YARN-524) TestYarnVersionInfo failing if
 generated properties doesn't include an SVN URL
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618756#comment-13618756 ] 

Steve Loughran commented on YARN-524:
-------------------------------------

I have a {{yarn-version-info.properties}} file of 
{code}
version=3.0.0-SNAPSHOT
revision=a0ba744f95eb220ba308376324179074dee68533
branch=stevel/YARN-117
user=stevel
date=2013-04-01T12:08Z
url=Unknown
srcChecksum=ab657ee8a99c56f22a874ca55268a24
{code}

Because of the url value, I get to see a stack trace
{code}
testVersionInfoGenerated(org.apache.hadoop.yarn.util.TestYarnVersionInfo)  Time elapsed: 63 sec  <<< FAILURE!
junit.framework.AssertionFailedError: getUrl returned Unknown
	at junit.framework.Assert.fail(Assert.java:47)
	at junit.framework.Assert.assertTrue(Assert.java:20)
	at org.apache.hadoop.yarn.util.TestYarnVersionInfo.testVersionInfoGenerated(TestYarnVersionInfo.java:43)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at junit.framework.TestCase.runTest(TestCase.java:168)
	at junit.framework.TestCase.runBare(TestCase.java:134)
	at junit.framework.TestResult$1.protect(TestResult.java:110)
	at junit.framework.TestResult.runProtected(TestResult.java:128)
	at junit.framework.TestResult.run(TestResult.java:113)
	at junit.framework.TestCase.run(TestCase.java:124)
	at junit.framework.TestSuite.runTest(TestSuite.java:243)
	at junit.framework.TestSuite.run(TestSuite.java:238)
	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
	at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
	at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)
{code}

I think the test assumes that there always is an SVN URL for YARN, but there's no requirement for this to be the case -not only does this git build clearly fail, but tarball builds may have the same characteristics 

I propose downgrading the URL test to those of the other assertions designed to work without svn or git
                
> TestYarnVersionInfo failing if generated properties doesn't include an SVN URL
> ------------------------------------------------------------------------------
>
>                 Key: YARN-524
>                 URL: https://issues.apache.org/jira/browse/YARN-524
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: api
>    Affects Versions: 3.0.0
>         Environment: OS/X with branch off github
>            Reporter: Steve Loughran
>            Priority: Minor
>
> {{TestYarnVersionInfo}} fails in the {{YarnVersionInfo.getUrl()}} call returns {{Unknown}} when that is the value inserted into the property file

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira