Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 65239F828 for ; Tue, 2 Apr 2013 07:13:18 +0000 (UTC) Received: (qmail 20105 invoked by uid 500); 2 Apr 2013 07:13:18 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 20059 invoked by uid 500); 2 Apr 2013 07:13:17 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 20039 invoked by uid 99); 2 Apr 2013 07:13:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Apr 2013 07:13:16 +0000 Date: Tue, 2 Apr 2013 07:13:16 +0000 (UTC) From: "Hudson (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-447) applicationComparator improvement for CS MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619581#comment-13619581 ] Hudson commented on YARN-447: ----------------------------- Integrated in Hadoop-trunk-Commit #3547 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3547/]) YARN-447. Move ApplicationComparator in CapacityScheduler to use comparator in ApplicationId. Contributed by Nemon Lou. (Revision 1463405) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1463405 Files : * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestUtils.java > applicationComparator improvement for CS > ---------------------------------------- > > Key: YARN-447 > URL: https://issues.apache.org/jira/browse/YARN-447 > Project: Hadoop YARN > Issue Type: Improvement > Components: scheduler > Affects Versions: 2.0.3-alpha > Reporter: nemon lou > Assignee: nemon lou > Priority: Minor > Fix For: 2.0.5-beta > > Attachments: YARN-447-trunk.patch, YARN-447-trunk.patch, YARN-447-trunk.patch, YARN-447-trunk.patch, YARN-447-trunk.patch > > > Now the compare code is : > return a1.getApplicationId().getId() - a2.getApplicationId().getId(); > Will be replaced with : > return a1.getApplicationId().compareTo(a2.getApplicationId()); > This will bring some benefits: > 1,leave applicationId compare logic to ApplicationId class; > 2,In future's HA mode,cluster time stamp may change,ApplicationId class already takes care of this condition. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira