hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hitesh Shah (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-561) Nodemanager should set some key information into the environment of every container that it launches.
Date Tue, 23 Apr 2013 18:21:17 GMT

    [ https://issues.apache.org/jira/browse/YARN-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639348#comment-13639348
] 

Hitesh Shah commented on YARN-561:
----------------------------------

Comments:

ApplicationAttemptId appAttemptIdEnv - please use a more appropriate variable name.
System.getenv(Environment.CONTAINER_ID.name()) - what happens if the container id is not set
in the env? 

{code}
     putEnvIfNotNull(environment, Environment.USER.name(), container.getUser());
{code}

Is the user allowed to override the user env var? 

{code}
+      LOG.info("Adding " + container.getContainer().getId()
           + " to application " + app.toString());
{code}
  - Doesn't the above happen so often that it will be a performance overhead? Should this
be changed to DEBUG? @Vinod, any comments on this? 




                
> Nodemanager should set some key information into the environment of every container that
it launches.
> -----------------------------------------------------------------------------------------------------
>
>                 Key: YARN-561
>                 URL: https://issues.apache.org/jira/browse/YARN-561
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Hitesh Shah
>            Assignee: Xuan Gong
>              Labels: usability
>         Attachments: YARN-561.10.patch, YARN-561.1.patch, YARN-561.2.patch, YARN-561.3.patch,
YARN-561.4.patch, YARN-561.5.patch, YARN-561.6.patch, YARN-561.7.patch, YARN-561.8.patch,
YARN-561.9.patch
>
>
> Information such as containerId, nodemanager hostname, nodemanager port is not set in
the environment when any container is launched. 
> For an AM, the RM does all of this for it but for a container launched by an application,
all of the above need to be set by the ApplicationMaster. 
> At the minimum, container id would be a useful piece of information. If the container
wishes to talk to its local NM, the nodemanager related information would also come in handy.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message