hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-535) TestUnmanagedAMLauncher can corrupt target/test-classes/yarn-site.xml during write phase, breaks later test runs
Date Tue, 09 Apr 2013 18:46:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626943#comment-13626943
] 

Chris Nauroth commented on YARN-535:
------------------------------------

Hi, Steve.  The patch looks good.  I verified that the test passes, running on Mac and Windows.

Do you also want to include {{TestDistributedShell#setup}} in the patch?  I expect the change
would be nearly identical.

                
> TestUnmanagedAMLauncher can corrupt target/test-classes/yarn-site.xml during write phase,
breaks later test runs
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-535
>                 URL: https://issues.apache.org/jira/browse/YARN-535
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>    Affects Versions: 3.0.0
>         Environment: OS/X laptop, HFS+ filesystem
>            Reporter: Steve Loughran
>            Priority: Minor
>         Attachments: YARN-535.patch
>
>
> the setup phase of {{TestUnmanagedAMLauncher}} overwrites {{yarn-site.xml}}. As {{Configuration.writeXml()}}
does a reread of all resources, this will break if the (open-for-writing) resource is already
visible as an empty file. 
> This leaves a corrupted {{target/test-classes/yarn-site.xml}}, which breaks later test
runs -because it is not overwritten by later incremental builds, due to timestamps.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message