hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kumar Vavilapalli (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-528) Make IDs read only
Date Tue, 02 Apr 2013 19:37:16 GMT

    [ https://issues.apache.org/jira/browse/YARN-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620170#comment-13620170
] 

Vinod Kumar Vavilapalli commented on YARN-528:
----------------------------------------------

bq. We have no plans to support any other serialization type, and the abstraction layer just,
makes it more difficult to change protocols, makes changing them more error prone, and slows
down the objects themselves. 
We have to make a call on this, don't think we explicitly took that decision yet. That said,
I am inclined to throw it away but there were a couple of reasons why we put this (like being
able to pass through unindentified fields for e.g. from new RM to new NM via old AM). I would
like a day or two to dig into those with knowledgeable folks offline. Thanks for your patience.

Oh, and let's separate the tickets into MR and YARN only changes please - there isn't any
pain as they are all orthogonal changes.
                
> Make IDs read only
> ------------------
>
>                 Key: YARN-528
>                 URL: https://issues.apache.org/jira/browse/YARN-528
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>         Attachments: YARN-528.txt, YARN-528.txt
>
>
> I really would like to rip out most if not all of the abstraction layer that sits in-between
Protocol Buffers, the RPC, and the actual user code.  We have no plans to support any other
serialization type, and the abstraction layer just, makes it more difficult to change protocols,
makes changing them more error prone, and slows down the objects themselves.  
> Completely doing that is a lot of work.  This JIRA is a first step towards that.  It
makes the various ID objects immutable.  If this patch is wel received I will try to go through
other objects/classes of objects and update them in a similar way.
> This is probably the last time we will be able to make a change like this before 2.0
stabilizes and YARN APIs will not be able to be changed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message