hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Siddharth Seth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-528) Make IDs read only
Date Mon, 29 Apr 2013 22:26:16 GMT

    [ https://issues.apache.org/jira/browse/YARN-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644970#comment-13644970

Siddharth Seth commented on YARN-528:

bq Thanks for doing this Sid. I started pulling on the string and there was just too much
involved, so I had to stop.
Any thoughts on the approach used in the patch. Making IDs immutable should be reasonably
fast using this - changing the PB mechanisms for other classes is a different beast though.
> Make IDs read only
> ------------------
>                 Key: YARN-528
>                 URL: https://issues.apache.org/jira/browse/YARN-528
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>         Attachments: y528_AppIdPart_01_Refactor.txt, y528_AppIdPart_02_AppIdChanges.txt,
y528_AppIdPart_03_fixUsage.txt, y528_ApplicationIdComplete_WIP.txt, YARN-528.txt, YARN-528.txt
> I really would like to rip out most if not all of the abstraction layer that sits in-between
Protocol Buffers, the RPC, and the actual user code.  We have no plans to support any other
serialization type, and the abstraction layer just, makes it more difficult to change protocols,
makes changing them more error prone, and slows down the objects themselves.  
> Completely doing that is a lot of work.  This JIRA is a first step towards that.  It
makes the various ID objects immutable.  If this patch is wel received I will try to go through
other objects/classes of objects and update them in a similar way.
> This is probably the last time we will be able to make a change like this before 2.0
stabilizes and YARN APIs will not be able to be changed.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message