hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuan Gong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-513) Verify all clients will wait for RM to restart
Date Mon, 29 Apr 2013 18:04:16 GMT

    [ https://issues.apache.org/jira/browse/YARN-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644695#comment-13644695

Xuan Gong commented on YARN-513:

bq:We could try to reuse existing RetryPolicy etc inside RMClient as long as we maintain the
RMClient abstraction. 
Reuse the RetryPolicy in new patch. The RetryInvocationHandler provides the retry logic in
its invoke method. We can reuse that

bq:Are we not missing an RMClient.disconnect()? This one would internally stop the proxy?
Yes, we need that. Adding the disconnect code in the new patch

bq:Looks like NMStatusUpdater.getRMClient() can be removed because createRMClient() is being
overridden by all tests.
Removed from the new patch

bq:Why are we throwing YARNException?
Original code throws the YarnException, now i want to keep consistant. And I think we will
change the exception thru YARN-142.

bq:Is any test explicitly testing the new code with a real RM? How about manually doing it?
Tested the new code in single node cluster
> Verify all clients will wait for RM to restart
> ----------------------------------------------
>                 Key: YARN-513
>                 URL: https://issues.apache.org/jira/browse/YARN-513
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Bikas Saha
>            Assignee: Xuan Gong
>         Attachments: YARN-513.1.patch, YARN-513.2.patch, YARN-513.3.patch
> When the RM is restarting, the NM, AM and Clients should wait for some time for the RM
to come back up.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message