hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-122) CompositeService should clone the Configurations it passes to children
Date Tue, 02 Apr 2013 17:25:18 GMT

    [ https://issues.apache.org/jira/browse/YARN-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620024#comment-13620024
] 

Steve Loughran commented on YARN-122:
-------------------------------------

This requires {{Configuration}} to implement {{clone()}} as a public method, so that any subclass
of it, such as {{YarnConfiguration}} will still be passed down to the children
                
> CompositeService should clone the Configurations it passes to children
> ----------------------------------------------------------------------
>
>                 Key: YARN-122
>                 URL: https://issues.apache.org/jira/browse/YARN-122
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Steve Loughran
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> {{CompositeService.init(Configuration)}} saves the configuration passed in *and* passes
the same instance down to all managed services. This means a change in the configuration of
one child could propagate to all the others.
> Unless this is desired, the configuration should be cloned for each child.
> Fast and easy fix; tests can be added to those coming in MAPREDUCE-4014

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message