Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Wed, 6 Mar 2013 17:58:14 +0000 (UTC)
From: "Bikas Saha (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12630191.1359658839513.392814.1362592694480@arcas>
In-Reply-To: <JIRA.12630191.1359658839513@arcas>
References: <JIRA.12630191.1359658839513@arcas>
Subject: [jira] [Commented] (YARN-369) Handle ( or throw a proper error when
 receiving) status updates from application masters that have not registered
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13594901#comment-13594901 ] 

Bikas Saha commented on YARN-369:
---------------------------------

The test is failing because of hitting an NPE in the hasApplication() code added in the patch. Why dont we remove that function. I dont think its required. Initializing responseId to -1 in registerNewApp() and setting it to 0 in registerApplication() should be enough.

	at org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService.hasApplicationMaster(ApplicationMasterService.java:249)
	at org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService.allocate(ApplicationMasterService.java:261)
	at org.apache.hadoop.yarn.server.resourcemanager.MockAM.allocate(MockAM.java:151)
	at org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart.testRMRestart(TestRMRestart.java:216)
                
> Handle ( or throw a proper error when receiving) status updates from application masters that have not registered
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-369
>                 URL: https://issues.apache.org/jira/browse/YARN-369
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.0.3-alpha, trunk-win
>            Reporter: Hitesh Shah
>            Assignee: Abhishek Kapoor
>         Attachments: YARN-369.patch
>
>
> Currently, an allocate call from an unregistered application is allowed and the status update for it throws a statemachine error that is silently dropped.
> org.apache.hadoop.yarn.state.InvalidStateTransitonException: Invalid event: STATUS_UPDATE at LAUNCHED
>        at org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:302)
>        at org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:43)
>        at org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine.doTransition(StateMachineFactory.java:445)
>        at org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptImpl.handle(RMAppAttemptImpl.java:588)
>        at org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptImpl.handle(RMAppAttemptImpl.java:99)
>        at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager$ApplicationAttemptEventDispatcher.handle(ResourceManager.java:471)
>        at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager$ApplicationAttemptEventDispatcher.handle(ResourceManager.java:452)
>        at org.apache.hadoop.yarn.event.AsyncDispatcher.dispatch(AsyncDispatcher.java:130)
>        at org.apache.hadoop.yarn.event.AsyncDispatcher$1.run(AsyncDispatcher.java:77)
>        at java.lang.Thread.run(Thread.java:680)
> ApplicationMasterService should likely throw an appropriate error for applications' requests that should not be handled in such cases.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira