Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Fri, 8 Mar 2013 19:26:12 +0000 (UTC)
From: "Robert Joseph Evans (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12550672.1334234324274.409664.1362770772925@arcas>
In-Reply-To: <JIRA.12550672.1334234324274@arcas>
References: <JIRA.12550672.1334234324274@arcas>
Subject: [jira] [Commented] (YARN-378) ApplicationMaster retry times should
 be set by Client
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597428#comment-13597428 ] 

Robert Joseph Evans commented on YARN-378:
------------------------------------------

>From a quick look it seems OK.

It would be nice for isLastAMRetry to remain private and have a getter.  That way it prevents unintended writes to it.

I also don't really like having the AM guess how many retries there will be.  I thought it was ugly when I add that code, and now that it logic is more complex I really know why.  Could you please file a JIRA so the RM and inform the AM how many AM retires it has, or if you have time just add it in as part of this JIRA.  That way the AM will never have to adjust its logic again.

Also could we make the code a little more robust.  In both the AM and the RM instead of checking for just -1 could you check for anything that is <= 0.  If anyone sets the retries to be that small it should use the default. I am not sure what having a max retries of -2 means and what it would do to an application.
                
> ApplicationMaster retry times should be set by Client
> -----------------------------------------------------
>
>                 Key: YARN-378
>                 URL: https://issues.apache.org/jira/browse/YARN-378
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client, resourcemanager
>         Environment: suse
>            Reporter: xieguiming
>            Assignee: Zhijie Shen
>              Labels: usability
>         Attachments: YARN-378_1.patch
>
>
> We should support that different client or user have different ApplicationMaster retry times. It also say that "yarn.resourcemanager.am.max-retries" should be set by client. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira