Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Thu, 21 Mar 2013 18:27:17 +0000 (UTC)
From: "Zhijie Shen (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12550672.1334234324274.28762.1363890437892@arcas>
In-Reply-To: <JIRA.12550672.1334234324274@arcas>
References: <JIRA.12550672.1334234324274@arcas>
Subject: [jira] [Commented] (YARN-378) ApplicationMaster retry times should
 be set by Client
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609267#comment-13609267 ] 

Zhijie Shen commented on YARN-378:
----------------------------------

{quote}
Where are we making sure that the global value in the conf is a sane value (ie admin has not mistakenly set a bad value)? 
{quote}
In ResourceManager#validateConfigs

{quote}
Can we write the if condition as if(foo < 0 || foo > MAX) then foo = MAX). The nested loop will make the reader of the code think more than needed IMO.
{quote}
Make sense, but I'd like to differentiate the two cases, and log warning messages. How about the following logic?
{code}
if (individual <= 0) {
  max = global;
  LOG.warn("invalid");
} else if (individual >= global) {
  max = global;
  LOG.warn("larger than global");
} else {
  max = individual;
}
{code}
                
> ApplicationMaster retry times should be set by Client
> -----------------------------------------------------
>
>                 Key: YARN-378
>                 URL: https://issues.apache.org/jira/browse/YARN-378
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client, resourcemanager
>         Environment: suse
>            Reporter: xieguiming
>            Assignee: Zhijie Shen
>              Labels: usability
>         Attachments: YARN-378_10.patch, YARN-378_1.patch, YARN-378_2.patch, YARN-378_3.patch, YARN-378_4.patch, YARN-378_5.patch, YARN-378_6.patch, YARN-378_6.patch, YARN-378_7.patch, YARN-378_8.patch, YARN-378_9.patch, YARN-378_MAPREDUCE-5062.patch
>
>
> We should support that different client or user have different ApplicationMaster retry times. It also say that "yarn.resourcemanager.am.max-retries" should be set by client. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira