hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikas Saha (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-450) Define value for * in the scheduling protocol
Date Fri, 22 Mar 2013 18:37:18 GMT

    [ https://issues.apache.org/jira/browse/YARN-450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13611054#comment-13611054
] 

Bikas Saha commented on YARN-450:
---------------------------------

Zhijie, you will need to make sure the string comparisons are done using .equals and not "==
or !=" since those just do object comparisons. Alternatively, you could define an isAnyLocation()
static final helper method that accepts a string location and returns true if it matches ANY.
This could be less error prone IMO.
                
> Define value for * in the scheduling protocol
> ---------------------------------------------
>
>                 Key: YARN-450
>                 URL: https://issues.apache.org/jira/browse/YARN-450
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>            Assignee: Zhijie Shen
>         Attachments: YARN-450_1.patch, YARN-450_2.patch, YARN-450_3.patch, YARN-450_4.patch
>
>
> The ResourceRequest has a string field to specify node/rack locations. For the cross-rack/cluster-wide
location (ie when there is no locality constraint) the "*" string is used everywhere. However,
its not defined anywhere and each piece of code either defines a local constant or uses the
string literal. Defining "*" in the protocol and removing other local references from the
code base will be good.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message