hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Joseph Evans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-237) Refreshing the RM page forgets how many rows I had in my Datatables
Date Fri, 08 Mar 2013 20:16:15 GMT

    [ https://issues.apache.org/jira/browse/YARN-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597508#comment-13597508
] 

Robert Joseph Evans commented on YARN-237:
------------------------------------------

I have a few more comments.

It is great that you fixed the issues, but now we have a leak in the browser.  You have tied
the table ID to the localStorage key, and then for a couple of tables you have included the
jobID in the table ID.  This means that new entries will be placed in the localStorage for
every job page I visit and those entires will never be deleted.

I see two ways to fix this.  We can ether change it over to be sessionStorage instead of localStorage,
because it goes away after the session ends.  Or we can remove the jobID from the table names.
If we remove the jobID corresponding tables on different pages will share a single state.
 If we use sessionStorage the data will only be saved for a given browser session.  If I close
the browser and reopen it the state will be lost. I tend to think the first one is preferable,
but that is just me. 

Also could you please update the code format to meet our guidelines.  There are a few places
where it does not meet the guidelines.
                
> Refreshing the RM page forgets how many rows I had in my Datatables
> -------------------------------------------------------------------
>
>                 Key: YARN-237
>                 URL: https://issues.apache.org/jira/browse/YARN-237
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>    Affects Versions: 2.0.2-alpha, 0.23.4, 3.0.0
>            Reporter: Ravi Prakash
>            Assignee: jian he
>              Labels: usability
>         Attachments: YARN-237.patch, YARN-237.v2.patch
>
>
> If I choose a 100 rows, and then refresh the page, DataTables goes back to showing me
20 rows.
> This user preference should be stored in a cookie.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message