hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "omkar vinit joshi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-109) .tmp file is not deleted for localized archives
Date Tue, 19 Mar 2013 23:41:15 GMT

    [ https://issues.apache.org/jira/browse/YARN-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13607042#comment-13607042
] 

omkar vinit joshi commented on YARN-109:
----------------------------------------

[~mayank_bansal] can we move the file deletion logic to the unpack method? I think that would
be the right place to delete the file as it is already happening for resource.getType() ==
FILE. (during renameTo call). The current patch won't handle the situation where
1) user has specified the file type as ARCHIVE but the extension is neither of these (.jar,.tar,.tar.gz,.tgz)
then it will add an incorrect error log message about file not deleted.
2) If the user has specified the file type as PATTERN then this will not remove the file.

Let me know what are your thoughts.

                
> .tmp file is not deleted for localized archives
> -----------------------------------------------
>
>                 Key: YARN-109
>                 URL: https://issues.apache.org/jira/browse/YARN-109
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 0.23.3, 2.0.0-alpha
>            Reporter: Jason Lowe
>            Assignee: Mayank Bansal
>         Attachments: YARN-109-trunk-1.patch, YARN-109-trunk.patch
>
>
> When archives are localized they are initially created as a .tmp file and unpacked from
that file.  However the .tmp file is not deleted afterwards.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message