Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Thu, 7 Feb 2013 12:41:20 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12629120.1359054555701.259860.1360240880313@arcas>
In-Reply-To: <JIRA.12629120.1359054555701@arcas>
References: <JIRA.12629120.1359054555701@arcas>
Subject: [jira] [Commented] (YARN-357) App submission should not be
 synchronized
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13573431#comment-13573431 ] 

Hudson commented on YARN-357:
-----------------------------

Integrated in Hadoop-Hdfs-0.23-Build #518 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/518/])
    YARN-357. App submission should not be synchronized (daryn) (Revision 1443048)

     Result = SUCCESS
daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1443048
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-yarn-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAppManager.java
* /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java

                
> App submission should not be synchronized
> -----------------------------------------
>
>                 Key: YARN-357
>                 URL: https://issues.apache.org/jira/browse/YARN-357
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 0.23.3, 3.0.0, 2.0.0-alpha
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 3.0.0, 2.0.3-alpha, 0.23.7
>
>         Attachments: YARN-357.branch-23.patch, YARN-357.patch, YARN-357.patch, YARN-357.txt
>
>
> MAPREDUCE-2953 fixed a race condition with querying of app status by making {{RMClientService#submitApplication}} synchronously invoke {{RMAppManager#submitApplication}}. However, the {{synchronized}} keyword was also added to {{RMAppManager#submitApplication}} with the comment:
> bq. I made the submitApplication synchronized to keep it consistent with the other routines in RMAppManager although I do not believe it needs it since the rmapp datastructure is already a concurrentMap and I don't see anything else that would be an issue.
> It's been observed that app submission latency is being unnecessarily impacted.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira