hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sandy Ryza (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-417) Add a poller that allows the AM to receive notifications when it is assigned containers
Date Wed, 27 Feb 2013 17:47:13 GMT

    [ https://issues.apache.org/jira/browse/YARN-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13588552#comment-13588552
] 

Sandy Ryza commented on YARN-417:
---------------------------------

Thanks for the interface proposal, Bikas.  It looks good to me.  Having a separate method
invocation for each completed container shouldn't have significant performance impact, as
Java inlines even virtual methods when it needs to (http://www.quora.com/How-many-CPU-instructions-are-typical-for-Java-method-call-overhead),
but the single call with the list doesn't seem any worse to me.

Nits:
* missing an onReboot method
* ContainerCompletionStatus is describing a cause more than a state, so a name like ContainerCompletionReason
fits a little better to me
* agree with Karthik that it would be much more intuitive for getContainerCompletionStatus
to be in ContainerStatus.  Is there a strong reason against this?

Attaching an updated proposal
                
> Add a poller that allows the AM to receive notifications when it is assigned containers
> ---------------------------------------------------------------------------------------
>
>                 Key: YARN-417
>                 URL: https://issues.apache.org/jira/browse/YARN-417
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, applications
>    Affects Versions: 2.0.3-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: AMRMClientAsync.java, YARN-417.patch, YarnAppMaster.java, YarnAppMasterListener.java
>
>
> Writing AMs would be easier for some if they did not have to handle heartbeating to the
RM on their own.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message