hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Graves (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (YARN-382) SchedulerUtils improve way normalizeRequest sets the resource capabilities
Date Wed, 06 Feb 2013 14:35:12 GMT

     [ https://issues.apache.org/jira/browse/YARN-382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Thomas Graves updated YARN-382:
-------------------------------

    Description: 
In YARN-370, we changed it from setting the capability to directly setting memory and cores:

-    ask.setCapability(normalized);
+    ask.getCapability().setMemory(normalized.getMemory());
+    ask.getCapability().setVirtualCores(normalized.getVirtualCores());

We did this because it is directly setting the values in the original resource object passed
in when the AM gets allocated and without it the AM doesn't get the resource normalized correctly
in the submission context. See YARN-370 for more details.

I think we should find a better way of doing this long term, one so we don't have to keep
adding things there when new resources are added, two because its a bit confusing as to what
its doing and prone to someone accidentally breaking it in the future again.  Something closer
to what Arun suggested in YARN-370 would be better but we need to make sure all the places
work and get some more testing on it before putting it in. 

  was:
In YARN-370, we changed it from setting the capability to directly setting memory and cores:

-    ask.setCapability(normalized);
+    ask.getCapability().setMemory(normalized.getMemory());
+    ask.getCapability().setVirtualCores(normalized.getVirtualCores());

We did this because before it is directly setting the values in the original resource object
passed in when the AM gets allocated and without it the AM doesn't get the resource normalized
correctly in the submission context. See YARN-370 for more details.

I think we should find a better way of doing this long term, one so we don't have to keep
adding things there when new resources are added, two because its a bit confusing as to what
its doing and prone to someone accidentally breaking it in the future again.  Something closer
to what Arun suggested in YARN-370 would be better but we need to make sure all the places
work and get some more testing on it before putting it in. 

    
> SchedulerUtils improve way normalizeRequest sets the resource capabilities
> --------------------------------------------------------------------------
>
>                 Key: YARN-382
>                 URL: https://issues.apache.org/jira/browse/YARN-382
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: scheduler
>    Affects Versions: 2.0.3-alpha
>            Reporter: Thomas Graves
>
> In YARN-370, we changed it from setting the capability to directly setting memory and
cores:
> -    ask.setCapability(normalized);
> +    ask.getCapability().setMemory(normalized.getMemory());
> +    ask.getCapability().setVirtualCores(normalized.getVirtualCores());
> We did this because it is directly setting the values in the original resource object
passed in when the AM gets allocated and without it the AM doesn't get the resource normalized
correctly in the submission context. See YARN-370 for more details.
> I think we should find a better way of doing this long term, one so we don't have to
keep adding things there when new resources are added, two because its a bit confusing as
to what its doing and prone to someone accidentally breaking it in the future again.  Something
closer to what Arun suggested in YARN-370 would be better but we need to make sure all the
places work and get some more testing on it before putting it in. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message