hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-359) NodeManager container-related tests fail on branch-trunk-win
Date Thu, 07 Feb 2013 04:47:13 GMT

    [ https://issues.apache.org/jira/browse/YARN-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13573183#comment-13573183
] 

Chris Nauroth commented on YARN-359:
------------------------------------

Thanks for the commit.

Sorry, Bikas.  I had forgotten the earlier discussion on YARN-233 when we chose to place these
methods in Shell, so I forgot to point this out to Vinod during his review of this patch.
 We don't currently have other uses for these methods.  However, a potential argument for
moving them back to Shell is that if a need arises, then developers are far more likely to
look in Shell for a utility method than to remember to promote something out of the nodemanager
codebase.

I'd be happy to do more refactoring if you want to discuss further.
                
> NodeManager container-related tests fail on branch-trunk-win
> ------------------------------------------------------------
>
>                 Key: YARN-359
>                 URL: https://issues.apache.org/jira/browse/YARN-359
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: YARN-359-branch-trunk-win.1.patch, YARN-359-branch-trunk-win.2.patch
>
>
> On branch-trunk-win, there are test failures in {{TestContainerManager}}, {{TestNodeManagerShutdown}},
{{TestContainerLaunch}}, and {{TestContainersMonitor}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message