hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Siddharth Seth (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (YARN-357) App submission should not be synchronized
Date Tue, 05 Feb 2013 21:59:14 GMT

     [ https://issues.apache.org/jira/browse/YARN-357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Siddharth Seth updated YARN-357:

    Attachment: YARN-357.txt

Pretty much the same patch, but with the mockito EventHandler replaced.
I'm +1 on the previous patch. Daryn, if you think this change to the unit test looks OK, please
go ahead and commit it. Thanks
> App submission should not be synchronized
> -----------------------------------------
>                 Key: YARN-357
>                 URL: https://issues.apache.org/jira/browse/YARN-357
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 0.23.3, 3.0.0, 2.0.0-alpha
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: YARN-357.patch, YARN-357.patch, YARN-357.txt
> MAPREDUCE-2953 fixed a race condition with querying of app status by making {{RMClientService#submitApplication}}
synchronously invoke {{RMAppManager#submitApplication}}. However, the {{synchronized}} keyword
was also added to {{RMAppManager#submitApplication}} with the comment:
> bq. I made the submitApplication synchronized to keep it consistent with the other routines
in RMAppManager although I do not believe it needs it since the rmapp datastructure is already
a concurrentMap and I don't see anything else that would be an issue.
> It's been observed that app submission latency is being unnecessarily impacted.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message