Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Tue, 18 Dec 2012 07:46:16 +0000 (UTC)
From: "Siddharth Seth (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12607315.1347472391035.21655.1355816776241@arcas>
In-Reply-To: <JIRA.12607315.1347472391035@arcas>
References: <JIRA.12607315.1347472391035@arcas>
Subject: [jira] [Commented] (YARN-103) Add a yarn AM - RM client module
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534733#comment-13534733 ] 

Siddharth Seth commented on YARN-103:
-------------------------------------

Apologies for taking ages to look at this. Some minor stuff pending.
- AMRMClient JavaDoc
  1) The javadoc for the ContainerRequest class has some typos and needs to be punctuated (instead of newlines)
  2) allocate javadoc - makes a reference to makeContainerRequest which is now called addContainerRequest. Also it'll be useful to mention the reboot flag which may be sent as part of the response.
- AMRMCLientImpl unregisterApplicationMaster - setAppAttemptId doesn't need to be in a synchronized block
- AMRMClientImpl - add/decContainerRequest rack null checks need fixing (host instead of rack)
- AMRMClientImpl.addResourceRequestToAsk - am not sure why this method is needed. A simple synchronized asks.add should be sufficient 

Also, would prefer the DistributedShell changes in a separate jira - just to keep this patch clean. Breaking that out of the current patch should be simple enough.

                
> Add a yarn AM - RM client module
> --------------------------------
>
>                 Key: YARN-103
>                 URL: https://issues.apache.org/jira/browse/YARN-103
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>         Attachments: YARN-103.1.patch, YARN-103.2.patch, YARN-103.3.patch, YARN-103.4.patch, YARN-103.4.wrapper.patch, YARN-103.5.patch, YARN-103.6.patch, YARN-103.7.patch
>
>
> Add a basic client wrapper library to the AM RM protocol in order to prevent proliferation of code being duplicated everywhere. Provide helper functions to perform reverse mapping of container requests to RM allocation resource request table format.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira