hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom White (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-103) Add a yarn AM - RM client module
Date Thu, 20 Dec 2012 12:25:15 GMT

    [ https://issues.apache.org/jira/browse/YARN-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536990#comment-13536990
] 

Tom White commented on YARN-103:
--------------------------------

Some feedback on the current patch:
* Why not use the existing ResourceRequest rather than creating a new type ContainerRequest?
Having two equivalent types seems confusing.
* Is the ANY constant meant to be used by users? It looks like you specify a ContainerRequest
with null hosts and racks in this case. If so, then it would be useful to add a constructor
that doesn't take hosts or racks for that case, although given my previous point it would
be easier to use ResourceRequest.
* {{assertTrue(containersRequestedRack == 2);}} appears on two successive lines. I think the
assertion should be about containersRequestedAny.
* "// do a few iterations to ensure RM is not going send new containers" - wait in the loop
to allow NMs to heartbeat?
                
> Add a yarn AM - RM client module
> --------------------------------
>
>                 Key: YARN-103
>                 URL: https://issues.apache.org/jira/browse/YARN-103
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>         Attachments: YARN-103.1.patch, YARN-103.2.patch, YARN-103.3.patch, YARN-103.4.patch,
YARN-103.4.wrapper.patch, YARN-103.5.patch, YARN-103.6.patch, YARN-103.7.patch
>
>
> Add a basic client wrapper library to the AM RM protocol in order to prevent proliferation
of code being duplicated everywhere. Provide helper functions to perform reverse mapping of
container requests to RM allocation resource request table format.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message