Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Tue, 6 Nov 2012 02:00:12 +0000 (UTC)
From: "Eli Collins (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <868725645.71915.1352167212333.JavaMail.jiratomcat@arcas>
Subject: [jira] [Created] (YARN-203) Fixup ResourceLocalizationService
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Eli Collins created YARN-203:
--------------------------------

             Summary: Fixup ResourceLocalizationService 
                 Key: YARN-203
                 URL: https://issues.apache.org/jira/browse/YARN-203
             Project: Hadoop YARN
          Issue Type: Bug
            Reporter: Eli Collins


The ResourceLocalizationService source isn't confidence inspiring, let's fix this up.

{code}
    // TODO this sucks. Fix it later
    @SuppressWarnings("unchecked") // dispatcher not typed
    LocalizerHeartbeatResponse update(
        List<LocalResourceStatus> remoteResourceStatuses) {
..
    // TODO: Synchronization
.. 
    // TODO: Why is this event going directly to the container. Why not
    // the resource itself? What happens to the resource? Is it removed?
{code}

{code}
      assert false; // TODO: FIXME assert doesn't help
                    // ^ The condition is benign. Tests should fail and it
                    //   should appear in logs, but it's an internal error
                    //   that should have no effect on applications
{code}

{code}
    // TODO: What to do with appLocalRsrcsTracker?
{code}

{code}
    public void addResource(LocalizerResourceRequestEvent request) {
      // TODO handle failures, cancellation, requests by other containers
{code}

{code}
    // TODO: decrement reference counts of all resources associated with this
    // app
{code}

{code}
        // TODO shutdown, better error handling esp. DU
{code}

{code}
                /* 
                 * Do not retry for now. Once failed is failed!
                 *  LocalizerResourceRequestEvent request = reqs.remove(0);

                pending.put(queue.submit(new FSDownload(
                    lfs, null, conf, publicDirs,
                    request.getResource().getRequest(), new Random())),
                    request);
                 */           
{code}

Also, PublicLocalizer has a lot of commented out code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira