Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Tue, 13 Nov 2012 06:17:13 +0000 (UTC)
From: "Jason Lowe (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <1984421119.106021.1352787433277.JavaMail.jiratomcat@arcas>
In-Reply-To: <1369256367.102706.1352753232470.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (YARN-212) NM state machine ignores an
 APPLICATION_CONTAINER_FINISHED event when it shouldn't
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495988#comment-13495988 ] 

Jason Lowe commented on YARN-212:
---------------------------------

+1, looks good overall.  Minor nit in ContainerImpl.java that it could use EnumSet to combine all the events being ignored in the DONE state into one addTransition call.
                
> NM state machine ignores an APPLICATION_CONTAINER_FINISHED event when it shouldn't
> ----------------------------------------------------------------------------------
>
>                 Key: YARN-212
>                 URL: https://issues.apache.org/jira/browse/YARN-212
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 0.23.4, 2.0.1-alpha
>            Reporter: Nathan Roberts
>            Assignee: Nathan Roberts
>            Priority: Blocker
>         Attachments: yarn-212.txt, yarn-212.txt
>
>
> The NM state machines can make the following two invalid state transitions when a speculative attempt is killed shortly after it gets started. When this happens the NM keeps the log aggregation context open for this application and therefore chews up FDs and leases on the NN, eventually running the NN out of FDs and bringing down the entire cluster.
> 2012-11-07 05:36:33,774 [AsyncDispatcher event handler] WARN org.apache.hadoop.yarn.server.nodemanager.containermanager.application.Application: Can't handle this event at current state
> org.apache.hadoop.yarn.state.InvalidStateTransitonException: Invalid event: APPLICATION_CONTAINER_FINISHED at INITING
> 2012-11-07 05:36:33,775 [AsyncDispatcher event handler] WARN org.apache.hadoop.yarn.server.nodemanager.containermanager.container.Container: Can't handle this event at current state: Current: [DONE], eventType: [INIT_CONTAINER]
> org.apache.hadoop.yarn.state.InvalidStateTransitonException: Invalid event: INIT_CONTAINER at DONE

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira