hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-184) Remove unnecessary locking in fair scheduler, and address findbugs excludes.
Date Thu, 15 Nov 2012 19:29:13 GMT

    [ https://issues.apache.org/jira/browse/YARN-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498263#comment-13498263
] 

Karthik Kambatla commented on YARN-184:
---------------------------------------

Thanks for the patch, Sandy. The patch looks mostly ready, I had the following minor comments:

# It might be better to lazily instantiate QueueManager - say before the corresponding initialize()
# Do you want to rephrase the comment preceding getAppWeight()? I don't think the synchronization
there is redundant, the method is synchronized to access sizeBasedWeight consistently (holding
same locks) across all accesses? Comments?
                
> Remove unnecessary locking in fair scheduler, and address findbugs excludes.
> ----------------------------------------------------------------------------
>
>                 Key: YARN-184
>                 URL: https://issues.apache.org/jira/browse/YARN-184
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-184-1.patch, YARN-184-2.patch, YARN-184.patch
>
>
> In YARN-12, locks were added to all fields of QueueManager to address findbugs.  In addition,
findbugs exclusions were added in response to MAPREDUCE-4439, without a deep look at the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message