hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikas Saha (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-72) NM should handle cleaning up containers when it shuts down ( and kill containers from an earlier instance when it comes back up after an unclean shutdown )
Date Thu, 29 Nov 2012 06:53:02 GMT

    [ https://issues.apache.org/jira/browse/YARN-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506268#comment-13506268
] 

Bikas Saha commented on YARN-72:
--------------------------------

Looks good. Minor nit

If these conf values have already been read to actual member values then we might want to
use them instead of reading the conf directly. This way we can account for any slop that those
values may have added of their own.
{code}
+    waitForContainersOnShutdownMillis =
+        conf.getLong(YarnConfiguration.NM_SLEEP_DELAY_BEFORE_SIGKILL_MS,
+            YarnConfiguration.DEFAULT_NM_SLEEP_DELAY_BEFORE_SIGKILL_MS) + 
+        conf.getLong(YarnConfiguration.NM_PROCESS_KILL_WAIT_MS,
+            YarnConfiguration.DEFAULT_NM_PROCESS_KILL_WAIT_MS) +
+        SHUTDOWN_CLEANUP_SLOP_MS;
{code}
                
> NM should handle cleaning up containers when it shuts down ( and kill containers from
an earlier instance when it comes back up after an unclean shutdown )
> -----------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-72
>                 URL: https://issues.apache.org/jira/browse/YARN-72
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: Hitesh Shah
>            Assignee: Sandy Ryza
>         Attachments: YARN-72-1.patch, YARN-72-2.patch, YARN-72-2.patch, YARN-72.patch
>
>
> Ideally, the NM should wait for a limited amount of time when it gets a shutdown signal
for existing containers to complete and kill the containers ( if we pick an aggressive approach
) after this time interval. 
> For NMs which come up after an unclean shutdown, the NM should look through its directories
for existing container.pids and try and kill an existing containers matching the pids found.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message