hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-233) YARN support for execution of container on Windows
Date Tue, 27 Nov 2012 18:03:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504800#comment-13504800

Chris Nauroth commented on YARN-233:

No worries at all.  Sometimes it's easy enough to just post multiple patches to see which
ideas stick.  Code is always less ambiguous than conversation.  :-)

ProcessIsAlive is similar in spirit to other Shell subclasses like DF and DU.  It's more code,
but it seems like this is the established pattern when you need a shell command with custom
error-handling.  (i.e. The command does not communicate error condition by a non-zero exit

Just to confirm so we can finish off this patch: we have 3 alternatives for implementing the
"winutils task isAlive" call.  1) put the call directly in the YARN code, 2) put the call
in Shell and change task.c to return non-zero exit code, 3) ProcessIsAlive subclass of Shell
and leave task.c alone.  Which do you prefer?  My preference is #1 as long as we're not expecting
any other parts of the codebase to need "winutils task isAlive".

Thanks again,

> YARN support for execution of container on Windows
> --------------------------------------------------
>                 Key: YARN-233
>                 URL: https://issues.apache.org/jira/browse/YARN-233
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: YARN-233-branch-trunk-win.3.patch, YARN-233-branch-trunk-win.patch,
> YARN container launch code requires updates for compatibility with Windows.  Instead
of launching and killing tasks via generated bash scripts and kill, use generated cmd scripts
and winutils for task management.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message