hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Joseph Evans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-204) test coverage for org.apache.hadoop.tools
Date Mon, 19 Nov 2012 17:55:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500440#comment-13500440
] 

Robert Joseph Evans commented on YARN-204:
------------------------------------------

I have a few more comments. Sorry to keep giving you more things to do.  These are mostly
just minor cleanup things.  I am a bit confused by TestExternalCall and what exactly it is
trying to test. I think I understand it, but it would be nice to have a comment in there that
explains what it is intended to test.

Also inside the tests in several places in the test you catch(Exception e) and then fail the
test.  I personally think it is cleaner to just let the test throw the exception and have
JUnit report the "Error".

In Test DistCh you are using a Random.  I am glad that there is a way to override the seed,
but I think it would be best to have a hard coded seed instead of just outputting it in the
logs.

There are a few places that there is old code that is commented out.  Please just remove that
code.
                
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>            Assignee: Aleksey Gorshkov
>         Attachments: YARN-204-branch-0.23-a.patch, YARN-204-branch-0.23.patch, YARN-204-branch-2-a.patch,
YARN-204-branch-2.patch, YARN-204-trunk-a.patch, YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message