hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom White (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-170) NodeManager stop() gets called twice on shutdown
Date Wed, 28 Nov 2012 12:02:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505384#comment-13505384
] 

Tom White commented on YARN-170:
--------------------------------

This looks like an overall improvement. A few minor comments on the latest patch:

* The reboot() method doesn't need to be public.
* The new classes are missing license headers.
* Please add a test for the change.
                
> NodeManager stop() gets called twice on shutdown
> ------------------------------------------------
>
>                 Key: YARN-170
>                 URL: https://issues.apache.org/jira/browse/YARN-170
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-170-1.patch, YARN-170.patch
>
>
> The stop method in the NodeManager gets called twice when the NodeManager is shut down
via the shutdown hook.
> The first is the stop that gets called directly by the shutdown hook.  The second occurs
when the NodeStatusUpdaterImpl is stopped.  The NodeManager responds to the NodeStatusUpdaterImpl
stop stateChanged event by stopping itself.  This is so that NodeStatusUpdaterImpl can notify
the NodeManager to stop, by stopping itself in response to a request from the ResourceManager
> This could be avoided if the NodeStatusUpdaterImpl were to stop the NodeManager by calling
its stop method directly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message