[ https://issues.apache.org/jira/browse/YARN-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502483#comment-13502483
]
Chris Nauroth commented on YARN-223:
------------------------------------
+1 patch looks good
I successfully applied the patch to current trunk, compiled, and ran tests. A potential improvement
is to add @Override annotations to the methods of TestResourceCalculatorProcessTree.EmptyProcessTree.
This isn't directly related to your current change though, so I leave it up to you whether
or not you want to update the patch.
> Change processTree interface to work better with native code
> ------------------------------------------------------------
>
> Key: YARN-223
> URL: https://issues.apache.org/jira/browse/YARN-223
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Radim Kolar
> Priority: Critical
> Attachments: pstree-update4.txt, pstree-update6.txt
>
>
> Problem is that on every update of processTree new object is required. This is undesired
when working with processTree implementation in native code.
> replace ProcessTree.getProcessTree() with updateProcessTree(). No new object allocation
is needed and it simplify application code a bit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
|