hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Radim Kolar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-223) Change processTree interface to work better with native code
Date Mon, 19 Nov 2012 17:47:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500432#comment-13500432
] 

Radim Kolar commented on YARN-223:
----------------------------------

problems with old code: if you are using some system resources such as file handles in native
library implementation of process tree then java can create kinda lot of objects of processTree
type which are not garbage collected and temporary leaks system resources.

If you start chaining references to original object, then you will have allocated system resources
just once but you will create long chain on objects which could not be GC'd by java until
all of them are unreferenced at end of container life.

I tried both and didn't liked it, after inspection of code calling psTree it was discovered
that simply updating object will be enough because code do not keeps old copy around while
creating a new one.
                
> Change processTree interface to work better with native code
> ------------------------------------------------------------
>
>                 Key: YARN-223
>                 URL: https://issues.apache.org/jira/browse/YARN-223
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Radim Kolar
>            Priority: Critical
>         Attachments: pstree-update.txt
>
>
> Problem is that on every update of processTree new object is required. This is undesired
when working with processTree implementation in native code.
> replace ProcessTree.getProcessTree() with updateProcessTree(). No new object allocation
is needed and it simplify application code a bit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message