Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Fri, 5 Oct 2012 10:29:47 +1100 (NCT)
From: "Hudson (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <382027849.2935.1349393387853.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (YARN-23) FairScheduler:
 FSQueueSchedulable#updateDemand() - potential redundant aggregation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469831#comment-13469831 ] 

Hudson commented on YARN-23:
----------------------------

Integrated in Hadoop-Common-trunk-Commit #2813 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2813/])
    YARN-23. FairScheduler: FSQueueSchedulable#updateDemand() - potential redundant aggregation. (kkambatl via tucu) (Revision 1394321)

     Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1394321
Files : 
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSQueueSchedulable.java
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestFSQueueSchedulable.java

                
> FairScheduler: FSQueueSchedulable#updateDemand() - potential redundant aggregation
> ----------------------------------------------------------------------------------
>
>                 Key: YARN-23
>                 URL: https://issues.apache.org/jira/browse/YARN-23
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: scheduler
>    Affects Versions: 2.0.0-alpha
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>             Fix For: 2.0.3-alpha
>
>         Attachments: trunk-MR-4518.patch, trunk-MR-4518.patch, YARN-23.patch, YARN-23.patch
>
>
> In FS, FSQueueSchedulable#updateDemand() limits the demand to maxTasks only after iterating though all the pools and computing the final demand. 
> By checking if the demand has reached maxTasks in every iteration, we can avoid redundant work, at the expense of one condition check every iteration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira